add dataset info #663
Merged
add dataset info #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dataset_refactor #663 +/- ##
====================================================
- Coverage 83.64% 82.58% -1.07%
====================================================
Files 178 184 +6
Lines 14195 13694 -501
Branches 2367 2321 -46
====================================================
- Hits 11874 11309 -565
- Misses 1714 1770 +56
- Partials 607 615 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
May 20, 2021
innerlee
reviewed
May 23, 2021
innerlee
reviewed
May 23, 2021
|
Another comment: the
|
|
@cherryjm Could you please help add |
|
@zengwang430521 Could you help check the color in |
|
Change
|
innerlee
reviewed
Aug 23, 2021
| from mmpose.datasets.pipelines import Compose | ||
|
|
||
|
|
||
| class AnimalBaseDataset(Dataset, metaclass=ABCMeta): |
There was a problem hiding this comment.
Keep a dummy class of AnimalBaseDataset here for compatibility
innerlee
reviewed
Aug 23, 2021
| @@ -108,7 +108,7 @@ def show_result(self, | |||
| bbox_color='green', | |||
| thickness=2, | |||
| pose_kpt_color=None, | |||
| pose_limb_color=None, | |||
| pose_link_color=None, | |||
There was a problem hiding this comment.
Compatibility for this change.
* fix some bugs in the unit test of smpl model. * reorganize `tests/` to solve importing issue (PEP 420) * fix deprecation warnings in unit tests Co-authored-by: ly015 <[email protected]>
* test the simple case using tmux to run multiple benchmark regression test tasks * modify and rename the config file and script * Delete config_list.yaml * modify the config and rename the filename * Delete test_benchmark_tmux.py * modify the script and rename the filename * Update setup.cfg * using mmcv.load to avoid introducing the extra dependency on yaml * fix some typo * refactor the config file and modify the script accordingly * modify the config and script * rename the config file
* Add pre-commit hook to automatically add copyright file header * update files with copyright header * Limit copyright checking in the first 2 lines of a file * Exclude configs in demo/ * set max-header-lines as 5 * rebase to master and add copyright to new files * move benchmark_regression into .dev_scripts/benchmark
* 2rd PR remove poseval * fix lint * revise the CN version Co-authored-by: ly015 <[email protected]>
* Add bc-breaking test for functions related to dataset_info * Rename DatasetInfo.dataset_info as DatasetInfo._dataset_info * Fix dataset_info of h36m dataset
6 tasks
ly015
added a commit
that referenced
this pull request
Sep 2, 2021
* Fix import and deprecation issues in unit tests (#871) * fix some bugs in the unit test of smpl model. * reorganize `tests/` to solve importing issue (PEP 420) * fix deprecation warnings in unit tests Co-authored-by: ly015 <[email protected]> * add benchmark regression test script with tmux (#849) * test the simple case using tmux to run multiple benchmark regression test tasks * modify and rename the config file and script * Delete config_list.yaml * modify the config and rename the filename * Delete test_benchmark_tmux.py * modify the script and rename the filename * Update setup.cfg * using mmcv.load to avoid introducing the extra dependency on yaml * fix some typo * refactor the config file and modify the script accordingly * modify the config and script * rename the config file * Correct dataset preparation guide of WFLW (#873) * add pr template (#875) * add CITATION.cff and update setup.py (#876) * Add copyright header and pre-commit hook (#872) * Add pre-commit hook to automatically add copyright file header * update files with copyright header * Limit copyright checking in the first 2 lines of a file * Exclude configs in demo/ * set max-header-lines as 5 * rebase to master and add copyright to new files * move benchmark_regression into .dev_scripts/benchmark * Translate tasks/2d_body_keypoint.md (#842) * 2rd PR remove poseval * fix lint * revise the CN version Co-authored-by: ly015 <[email protected]> * fix some bugs in the unit test of smpl model. * * reorganiz `tests/` to solve importing issue (PEP 420) * add dataset info * fix lint * * fix wrongly modified parts in previous rebase * fix lint * rename datasets/_base_ as datasets/base * resolve compatibility of pose_limb_color * Add dummy dataset base classes with old names for compatibility * * Rewrite relative unittest based on dataset_info * Add bc-breaking test for functions related to dataset_info * Rename DatasetInfo.dataset_info as DatasetInfo._dataset_info * Fix dataset_info of h36m dataset * Handle breaking change pose_limb_color -> pose_link_color * add unittest for old-fashioned dataset initialization without dataset_info * resolve naming conflict in unittests Co-authored-by: zengwang430521 <[email protected]> Co-authored-by: ly015 <[email protected]>
ly015
added a commit
that referenced
this pull request
Sep 7, 2021
* add dataset info (#663) * Fix import and deprecation issues in unit tests (#871) * fix some bugs in the unit test of smpl model. * reorganize `tests/` to solve importing issue (PEP 420) * fix deprecation warnings in unit tests Co-authored-by: ly015 <[email protected]> * add benchmark regression test script with tmux (#849) * test the simple case using tmux to run multiple benchmark regression test tasks * modify and rename the config file and script * Delete config_list.yaml * modify the config and rename the filename * Delete test_benchmark_tmux.py * modify the script and rename the filename * Update setup.cfg * using mmcv.load to avoid introducing the extra dependency on yaml * fix some typo * refactor the config file and modify the script accordingly * modify the config and script * rename the config file * Correct dataset preparation guide of WFLW (#873) * add pr template (#875) * add CITATION.cff and update setup.py (#876) * Add copyright header and pre-commit hook (#872) * Add pre-commit hook to automatically add copyright file header * update files with copyright header * Limit copyright checking in the first 2 lines of a file * Exclude configs in demo/ * set max-header-lines as 5 * rebase to master and add copyright to new files * move benchmark_regression into .dev_scripts/benchmark * Translate tasks/2d_body_keypoint.md (#842) * 2rd PR remove poseval * fix lint * revise the CN version Co-authored-by: ly015 <[email protected]> * fix some bugs in the unit test of smpl model. * * reorganiz `tests/` to solve importing issue (PEP 420) * add dataset info * fix lint * * fix wrongly modified parts in previous rebase * fix lint * rename datasets/_base_ as datasets/base * resolve compatibility of pose_limb_color * Add dummy dataset base classes with old names for compatibility * * Rewrite relative unittest based on dataset_info * Add bc-breaking test for functions related to dataset_info * Rename DatasetInfo.dataset_info as DatasetInfo._dataset_info * Fix dataset_info of h36m dataset * Handle breaking change pose_limb_color -> pose_link_color * add unittest for old-fashioned dataset initialization without dataset_info * resolve naming conflict in unittests Co-authored-by: zengwang430521 <[email protected]> Co-authored-by: ly015 <[email protected]> * fix typo * fix typo Co-authored-by: Jas <[email protected]> Co-authored-by: zengwang430521 <[email protected]>
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
* add dataset info (open-mmlab#663) * Fix import and deprecation issues in unit tests (open-mmlab#871) * fix some bugs in the unit test of smpl model. * reorganize `tests/` to solve importing issue (PEP 420) * fix deprecation warnings in unit tests Co-authored-by: ly015 <[email protected]> * add benchmark regression test script with tmux (open-mmlab#849) * test the simple case using tmux to run multiple benchmark regression test tasks * modify and rename the config file and script * Delete config_list.yaml * modify the config and rename the filename * Delete test_benchmark_tmux.py * modify the script and rename the filename * Update setup.cfg * using mmcv.load to avoid introducing the extra dependency on yaml * fix some typo * refactor the config file and modify the script accordingly * modify the config and script * rename the config file * Correct dataset preparation guide of WFLW (open-mmlab#873) * add pr template (open-mmlab#875) * add CITATION.cff and update setup.py (open-mmlab#876) * Add copyright header and pre-commit hook (open-mmlab#872) * Add pre-commit hook to automatically add copyright file header * update files with copyright header * Limit copyright checking in the first 2 lines of a file * Exclude configs in demo/ * set max-header-lines as 5 * rebase to master and add copyright to new files * move benchmark_regression into .dev_scripts/benchmark * Translate tasks/2d_body_keypoint.md (open-mmlab#842) * 2rd PR remove poseval * fix lint * revise the CN version Co-authored-by: ly015 <[email protected]> * fix some bugs in the unit test of smpl model. * * reorganiz `tests/` to solve importing issue (PEP 420) * add dataset info * fix lint * * fix wrongly modified parts in previous rebase * fix lint * rename datasets/_base_ as datasets/base * resolve compatibility of pose_limb_color * Add dummy dataset base classes with old names for compatibility * * Rewrite relative unittest based on dataset_info * Add bc-breaking test for functions related to dataset_info * Rename DatasetInfo.dataset_info as DatasetInfo._dataset_info * Fix dataset_info of h36m dataset * Handle breaking change pose_limb_color -> pose_link_color * add unittest for old-fashioned dataset initialization without dataset_info * resolve naming conflict in unittests Co-authored-by: zengwang430521 <[email protected]> Co-authored-by: ly015 <[email protected]> * fix typo * fix typo Co-authored-by: Jas <[email protected]> Co-authored-by: zengwang430521 <[email protected]>
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* add dataset info (open-mmlab#663) * Fix import and deprecation issues in unit tests (open-mmlab#871) * fix some bugs in the unit test of smpl model. * reorganize `tests/` to solve importing issue (PEP 420) * fix deprecation warnings in unit tests Co-authored-by: ly015 <[email protected]> * add benchmark regression test script with tmux (open-mmlab#849) * test the simple case using tmux to run multiple benchmark regression test tasks * modify and rename the config file and script * Delete config_list.yaml * modify the config and rename the filename * Delete test_benchmark_tmux.py * modify the script and rename the filename * Update setup.cfg * using mmcv.load to avoid introducing the extra dependency on yaml * fix some typo * refactor the config file and modify the script accordingly * modify the config and script * rename the config file * Correct dataset preparation guide of WFLW (open-mmlab#873) * add pr template (open-mmlab#875) * add CITATION.cff and update setup.py (open-mmlab#876) * Add copyright header and pre-commit hook (open-mmlab#872) * Add pre-commit hook to automatically add copyright file header * update files with copyright header * Limit copyright checking in the first 2 lines of a file * Exclude configs in demo/ * set max-header-lines as 5 * rebase to master and add copyright to new files * move benchmark_regression into .dev_scripts/benchmark * Translate tasks/2d_body_keypoint.md (open-mmlab#842) * 2rd PR remove poseval * fix lint * revise the CN version Co-authored-by: ly015 <[email protected]> * fix some bugs in the unit test of smpl model. * * reorganiz `tests/` to solve importing issue (PEP 420) * add dataset info * fix lint * * fix wrongly modified parts in previous rebase * fix lint * rename datasets/_base_ as datasets/base * resolve compatibility of pose_limb_color * Add dummy dataset base classes with old names for compatibility * * Rewrite relative unittest based on dataset_info * Add bc-breaking test for functions related to dataset_info * Rename DatasetInfo.dataset_info as DatasetInfo._dataset_info * Fix dataset_info of h36m dataset * Handle breaking change pose_limb_color -> pose_link_color * add unittest for old-fashioned dataset initialization without dataset_info * resolve naming conflict in unittests Co-authored-by: zengwang430521 <[email protected]> Co-authored-by: ly015 <[email protected]> * fix typo * fix typo Co-authored-by: Jas <[email protected]> Co-authored-by: zengwang430521 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires mmcv-full (latest version). open-mmlab/mmcv#1083
Blocked by mmcv release.
===================================================================================
dataset_infofile for each dataset, e.g. "dataset_info/atrw.py". This file contains all information about the dataset: (1)dataset_name(2)paper_info(3)keypoint_info(4)skeleton_info.datasetwithdataset_infoininference.py.skeleton._base_datasets inmmpose/datasets/datasets/